Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.16] WIP: NOMERGE: DNM: consume u/s LLC alignment support #2128

Open
wants to merge 5 commits into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] WIP: NOMERGE: DNM: consume u/s LLC alignment support #2128

wants to merge 5 commits into from

Conversation

ffromani
Copy link

@ffromani ffromani commented Nov 6, 2024

WIP DNM

sphrasavath and others added 4 commits November 6, 2024 17:28
@sphrasavath @ffromani
Add takeByTopologyUnCoreCachePacked if policy option align-cpus-by-u…
46dc787 
…ncorecache is enabled.

 Adding new function to evaluate uncore cache id. Reverse allocation logic.
 Implement preferAlignByUncorecache within TakeByTopologyNUMAPacked, along with new test cases.

(cherry picked from commit 3f459f2)
@wongchar @ffromani
update comments
c52de76 
(cherry picked from commit b86eb19)
@ffromani
UPSTREAM: <carry>: adapt to the old API
10bf2a2 
update code and tests to work with older codebase.

This PR can be dropped when we rebase.

Signed-off-by: Francesco Romani <[email protected]>
@ffromani
UPSTREAM: <carry>: require configuration file enablement
8ee9de3 
similarly to what we do for the managed CPU (aka workload partitioning)
feature, introduce a master configuration file
`/etc/kubernetes/openshift-llc-alignment` which needs to be present for
the LLC alignment feature to be activated, in addition to the policy
option being required.

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Nov 6, 2024
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from mrunalp and rphillips November 6, 2024 17:33
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ffromani
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
WIP: DNM: promote the LLC Align feature gate to beta
919c764 
until we are clear how the final enablement would look
like, promote the feature gate to beta to reduce
the friction - OCP doesn't allow to set alpha FGs.

Signed-off-by: Francesco Romani <[email protected]>
@openshift-ci-robot
Copy link

@ffromani: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 7, 2024

@ffromani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-commits 919c764 link true /test verify-commits
ci/prow/e2e-agnostic-ovn-cmd 919c764 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ffromani ffromani mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@rphillips rphillips Awaiting requested review from rphillips

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ffromani @openshift-ci-robot @sphrasavath @wongchar